The deletion of chapter data was done in its own transaction. Thus, when the update or insertion failed later on, the deletion was not rolled back
fixes#2031
Co-authored-by: Mitchell Syer <Syer10@users.noreply.github.com>
Fixes problems like
```
java.lang.ClassNotFoundException: org.cef.callback.CefResourceReadCallback_N
```
and
```
Exception in thread "Thread-584" java.lang.NoSuchMethodError: open
```
* Reset update-flag on uninstall
If there is an update available when the extension is uninstalled, the
table will still have the update flag, which makes no sense if it is not
installed.
Example:
```
{
"pkgName": "eu.kanade.tachiyomi.extension.en.comix",
"name": "Comix",
"lang": "en",
"versionCode": 20,
"versionName": "1.4.20",
"iconUrl": "/api/v1/extension/icon/tachiyomi-en.comix-v1.4.20.apk",
"repo": "<hidden>",
"isNsfw": true,
"isInstalled": false,
"isObsolete": false,
"hasUpdate": true,
"__typename": "ExtensionType"
},
```
* Update changelog
* Standardize toSqlName
* Rename Meta Key db field since KEY is now a reserved name in H2
* Changelog entry
* Use toSqlName
* Forgot this key
* Catch any exception
* Update graphqlkotlin to v9
* Update to the v10 alpha due to nullability issues in v9
* Fixes
* Remove asDataFetcherResult
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Syer10 <syer10@users.noreply.github.com>
Using a script to inject the base tag is unnecessarily complex as well as it is introducing an issue where the initial requests will potentially fail, due to the base tag not being injected yet.
See https://github.com/Suwayomi/Suwayomi-WebUI/issues/1096, same issue applies when a subpath is set up which can't be fixed on the client side
* fix: support for POST requests
Works with Flaresolverr. Required for Kagane.
Byparr is not a drop-in replacement, it just ignores the `cmd` and interprets everything as a GET request.
* Use encodeToString instead
* linting
* Use FormBody for encoding
Co-authored-by: Mitchell Syer <Syer10@users.noreply.github.com>
* Add missing imports
* linting, again
---------
Co-authored-by: Mitchell Syer <Syer10@users.noreply.github.com>
I mistakenly thought that the suwayomi schema was always being used and therefore did not think a migration for the fix b4595b70d6 was necessary.
However, this was only the case in case the username was set to suwayomi. Otherwise, the public schema was being used.
Thus, we need to migrate the data from the public schema to the suwayomi schema in these cases.
* Set default schema for postgresql db
The schema was only set once during startup. This is, however, only set for the current connection. So when using hikaricp, depending on which connection was used, the schema might have been set, or it might not have been set.
fixes#1670
* Revert "Fix database connection and errors (#1681)"
This reverts commit 2e0f72f182.
Not necessary anymore as the issue that this change intended to fix is now fixed with 091206800025ed9370d611e7ca3430ab409a0cb2
* fix: Do not return `inputStream` from conversion
The returned value must be owned, since the caller closes the input
stream on success
* fix: Assume a conversion error consumes the input stream
e.g. converting an ARGB png to jpeg will throw "bogus colorspace", but
only after the inputstream is consumed. so in case of an exception, we
have to assume that the stream is broken and re-open the page from cache
The "download conversions headers" caused a SerializationException.
kotlinx.serialization.SerializationException: 'null' is not supported as the value of collection types in ProtoBuf
The server setting updater passed an already converted value to the setting validator, which then tried to convert the value again, which caused an error
Regression aa8d27f679
* Move the "group" arg at the second position after "protoNumber"
To make it consistent for all settings
* Improve server config non privacy safe setting handling
---------
Co-authored-by: Mitchell Syer <Syer10@users.noreply.github.com>
* Fix typo in setting validation error message
* Convert value to internal type before validating it
* Only update setting in case value is valid
* Ignore settings validation errors on backup restore
* Remove potential not privacy safe value from logs
