temple/Suwayomi-Server
1
0
Fork 0
mirror of https://github.com/Suwayomi/Suwayomi-Server.git synced 2026-07-03 10:54:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix/failing track progress update for logged out trackers (#953)

Browse Source 
* Refresh track record only when logged in

In case one tracker was logged out, the refresh failed with an unauthenticated error and caused the other trackers to not get updated

* Prevent chapter track update from failing due to failure of other tracker

* Change level of log to "info"
This commit is contained in:
schroda
2024-06-01 18:22:25 +02:00
committed by GitHub
parent 6dd9ed7fb0
commit fc2f5ffdf9
1 changed files with 40 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/track/Track.kt
View File

@@ -281,7 +281,7 @@ object Track {
val chapter = queryMaxReadChapter(mangaId) val chapter = queryMaxReadChapter(mangaId)
val chapterNumber = chapter?.get(ChapterTable.chapter_number) val chapterNumber = chapter?.get(ChapterTable.chapter_number)
logger.debug { logger.info {
"trackChapter(mangaId= $mangaId): maxReadChapter= #$chapterNumber ${chapter?.get(ChapterTable.name)}" "trackChapter(mangaId= $mangaId): maxReadChapter= #$chapterNumber ${chapter?.get(ChapterTable.name)}"
} }
@@ -310,30 +310,51 @@ object Track {
} }
records.forEach { records.forEach {
val tracker = TrackerManager.getTracker(it[TrackRecordTable.trackerId]) ?: return@forEach try {
trackChapterForTracker(it, chapterNumber)
val localLastReadChapter = it[TrackRecordTable.lastChapterRead] } catch (e: Exception) {
KotlinLogging.logger { "${logger.name}::trackChapter(mangaId= $mangaId, chapterNumber= $chapterNumber)" }
val log = KotlinLogging.logger { "${logger.name}::trackChapter(mangaId= $mangaId, chapterNumber= $chapterNumber)" } .error(e) { "failed due to" }
if (localLastReadChapter == chapterNumber) {
log.debug { "new chapter is the same as the local last read chapter" }
return@forEach
} }
}
}
val track = it.toTrack() private suspend fun trackChapterForTracker(
tracker.refresh(track) it: ResultRow,
chapterNumber: Double,
) {
val tracker = TrackerManager.getTracker(it[TrackRecordTable.trackerId]) ?: return
val track = it.toTrack()
val log =
KotlinLogging.logger {
"${logger.name}::trackChapterForTracker(chapterNumber= $chapterNumber, tracker= ${tracker.id}, recordId= ${track.id})"
}
log.debug { "called for $tracker, ${track.title} (recordId= ${track.id}, mangaId= ${track.manga_id})" }
val localLastReadChapter = it[TrackRecordTable.lastChapterRead]
if (localLastReadChapter == chapterNumber) {
log.debug { "new chapter is the same as the local last read chapter" }
return
}
if (!tracker.isLoggedIn) {
upsertTrackRecord(track) upsertTrackRecord(track)
return
}
val lastChapterRead = track.last_chapter_read tracker.refresh(track)
upsertTrackRecord(track)
log.debug { "tracker= $tracker, remoteLastReadChapter= $lastChapterRead" } val lastChapterRead = track.last_chapter_read
if (tracker.isLoggedIn && chapterNumber > lastChapterRead) { log.debug { "remoteLastReadChapter= $lastChapterRead" }
track.last_chapter_read = chapterNumber.toFloat()
tracker.update(track, true) if (chapterNumber > lastChapterRead) {
upsertTrackRecord(track) track.last_chapter_read = chapterNumber.toFloat()
} tracker.update(track, true)
upsertTrackRecord(track)
} }
} }