Handle missing objects in graphql

This commit is contained in:
Syer10
2023-04-02 20:39:56 -04:00
parent 52bda2c080
commit e8c2bad187
9 changed files with 50 additions and 27 deletions

View File

@@ -21,14 +21,16 @@ import suwayomi.tachidesk.manga.model.table.CategoryMangaTable
import suwayomi.tachidesk.manga.model.table.CategoryTable import suwayomi.tachidesk.manga.model.table.CategoryTable
import suwayomi.tachidesk.server.JavalinSetup.future import suwayomi.tachidesk.server.JavalinSetup.future
class CategoryDataLoader : KotlinDataLoader<Int, CategoryType> { class CategoryDataLoader : KotlinDataLoader<Int, CategoryType?> {
override val dataLoaderName = "CategoryDataLoader" override val dataLoaderName = "CategoryDataLoader"
override fun getDataLoader(): DataLoader<Int, CategoryType> = DataLoaderFactory.newDataLoader<Int, CategoryType> { ids -> override fun getDataLoader(): DataLoader<Int, CategoryType?> = DataLoaderFactory.newDataLoader { ids ->
future { future {
transaction { transaction {
addLogger(Slf4jSqlDebugLogger) addLogger(Slf4jSqlDebugLogger)
CategoryTable.select { CategoryTable.id inList ids } val categories = CategoryTable.select { CategoryTable.id inList ids }
.map { CategoryType(it) } .map { CategoryType(it) }
.associateBy { it.id }
ids.map { categories[it] }
} }
} }
} }

View File

@@ -20,14 +20,16 @@ import suwayomi.tachidesk.graphql.types.ChapterType
import suwayomi.tachidesk.manga.model.table.ChapterTable import suwayomi.tachidesk.manga.model.table.ChapterTable
import suwayomi.tachidesk.server.JavalinSetup.future import suwayomi.tachidesk.server.JavalinSetup.future
class ChapterDataLoader : KotlinDataLoader<Int, ChapterType> { class ChapterDataLoader : KotlinDataLoader<Int, ChapterType?> {
override val dataLoaderName = "ChapterDataLoader" override val dataLoaderName = "ChapterDataLoader"
override fun getDataLoader(): DataLoader<Int, ChapterType> = DataLoaderFactory.newDataLoader<Int, ChapterType> { ids -> override fun getDataLoader(): DataLoader<Int, ChapterType?> = DataLoaderFactory.newDataLoader<Int, ChapterType> { ids ->
future { future {
transaction { transaction {
addLogger(Slf4jSqlDebugLogger) addLogger(Slf4jSqlDebugLogger)
ChapterTable.select { ChapterTable.id inList ids } val chapters = ChapterTable.select { ChapterTable.id inList ids }
.map { ChapterType(it) } .map { ChapterType(it) }
.associateBy { it.id }
ids.map { chapters[it] }
} }
} }
} }

View File

@@ -19,28 +19,44 @@ import suwayomi.tachidesk.manga.model.table.ExtensionTable
import suwayomi.tachidesk.manga.model.table.SourceTable import suwayomi.tachidesk.manga.model.table.SourceTable
import suwayomi.tachidesk.server.JavalinSetup.future import suwayomi.tachidesk.server.JavalinSetup.future
class ExtensionDataLoader : KotlinDataLoader<String, ExtensionType> { class ExtensionDataLoader : KotlinDataLoader<String, ExtensionType?> {
override val dataLoaderName = "ExtensionDataLoader" override val dataLoaderName = "ExtensionDataLoader"
override fun getDataLoader(): DataLoader<String, ExtensionType> = DataLoaderFactory.newDataLoader { ids -> override fun getDataLoader(): DataLoader<String, ExtensionType?> = DataLoaderFactory.newDataLoader { ids ->
future { future {
transaction { transaction {
addLogger(Slf4jSqlDebugLogger) addLogger(Slf4jSqlDebugLogger)
ExtensionTable.select { ExtensionTable.pkgName inList ids } val extensions = ExtensionTable.select { ExtensionTable.pkgName inList ids }
.map { ExtensionType(it) } .map { ExtensionType(it) }
.associateBy { it.pkgName }
ids.map { extensions[it] }
} }
} }
} }
} }
class ExtensionForSourceDataLoader : KotlinDataLoader<Long, ExtensionType> { class ExtensionForSourceDataLoader : KotlinDataLoader<Long, ExtensionType?> {
override val dataLoaderName = "ExtensionForSourceDataLoader" override val dataLoaderName = "ExtensionForSourceDataLoader"
override fun getDataLoader(): DataLoader<Long, ExtensionType> = DataLoaderFactory.newDataLoader { ids -> override fun getDataLoader(): DataLoader<Long, ExtensionType?> = DataLoaderFactory.newDataLoader { ids ->
future { future {
transaction { transaction {
addLogger(Slf4jSqlDebugLogger) addLogger(Slf4jSqlDebugLogger)
ExtensionTable.innerJoin(SourceTable) val extensions = ExtensionTable.innerJoin(SourceTable)
.select { SourceTable.id inList ids } .select { SourceTable.id inList ids }
.map { ExtensionType(it) } .toList()
.map { Triple(it[SourceTable.id].value, it[ExtensionTable.pkgName], it) }
.let { triples ->
val sources = buildMap {
triples.forEach {
if (!containsKey(it.second)) {
put(it.second, ExtensionType(it.third))
}
}
}
triples.associate {
it.first to sources[it.second]
}
}
ids.map { extensions[it] }
} }
} }
} }

View File

@@ -21,14 +21,16 @@ import suwayomi.tachidesk.manga.model.table.CategoryMangaTable
import suwayomi.tachidesk.manga.model.table.MangaTable import suwayomi.tachidesk.manga.model.table.MangaTable
import suwayomi.tachidesk.server.JavalinSetup.future import suwayomi.tachidesk.server.JavalinSetup.future
class MangaDataLoader : KotlinDataLoader<Int, MangaType> { class MangaDataLoader : KotlinDataLoader<Int, MangaType?> {
override val dataLoaderName = "MangaDataLoader" override val dataLoaderName = "MangaDataLoader"
override fun getDataLoader(): DataLoader<Int, MangaType> = DataLoaderFactory.newDataLoader<Int, MangaType> { ids -> override fun getDataLoader(): DataLoader<Int, MangaType?> = DataLoaderFactory.newDataLoader { ids ->
future { future {
transaction { transaction {
addLogger(Slf4jSqlDebugLogger) addLogger(Slf4jSqlDebugLogger)
MangaTable.select { MangaTable.id inList ids } val manga = MangaTable.select { MangaTable.id inList ids }
.map { MangaType(it) } .map { MangaType(it) }
.associateBy { it.id }
ids.map { manga[it] }
} }
} }
} }

View File

@@ -28,9 +28,10 @@ class SourceDataLoader : KotlinDataLoader<Long, SourceType?> {
future { future {
transaction { transaction {
addLogger(Slf4jSqlDebugLogger) addLogger(Slf4jSqlDebugLogger)
SourceTable.select { SourceTable.id inList ids }.map { val source = SourceTable.select { SourceTable.id inList ids }
SourceType(it) .mapNotNull { SourceType(it) }
} .associateBy { it.id }
ids.map { source[it] }
} }
} }
} }

View File

@@ -33,8 +33,8 @@ import java.util.concurrent.CompletableFuture
* - Delete meta * - Delete meta
*/ */
class CategoryQuery { class CategoryQuery {
fun category(dataFetchingEnvironment: DataFetchingEnvironment, id: Int): CompletableFuture<CategoryType> { fun category(dataFetchingEnvironment: DataFetchingEnvironment, id: Int): CompletableFuture<CategoryType?> {
return dataFetchingEnvironment.getValueFromDataLoader<Int, CategoryType>("CategoryDataLoader", id) return dataFetchingEnvironment.getValueFromDataLoader("CategoryDataLoader", id)
} }
enum class CategorySort { enum class CategorySort {

View File

@@ -33,8 +33,8 @@ import java.util.concurrent.CompletableFuture
* - Delete download * - Delete download
*/ */
class ChapterQuery { class ChapterQuery {
fun chapter(dataFetchingEnvironment: DataFetchingEnvironment, id: Int): CompletableFuture<ChapterType> { fun chapter(dataFetchingEnvironment: DataFetchingEnvironment, id: Int): CompletableFuture<ChapterType?> {
return dataFetchingEnvironment.getValueFromDataLoader<Int, ChapterType>("ChapterDataLoader", id) return dataFetchingEnvironment.getValueFromDataLoader("ChapterDataLoader", id)
} }
enum class ChapterSort { enum class ChapterSort {

View File

@@ -35,8 +35,8 @@ import java.util.concurrent.CompletableFuture
* - Check for updates (global mutation?) * - Check for updates (global mutation?)
*/ */
class ExtensionQuery { class ExtensionQuery {
fun extension(dataFetchingEnvironment: DataFetchingEnvironment, pkgName: String): CompletableFuture<ExtensionType> { fun extension(dataFetchingEnvironment: DataFetchingEnvironment, pkgName: String): CompletableFuture<ExtensionType?> {
return dataFetchingEnvironment.getValueFromDataLoader<String, ExtensionType>("ExtensionDataLoader", pkgName) return dataFetchingEnvironment.getValueFromDataLoader("ExtensionDataLoader", pkgName)
} }
fun extensions(): ExtensionNodeList { fun extensions(): ExtensionNodeList {

View File

@@ -39,8 +39,8 @@ import java.util.concurrent.CompletableFuture
* - Delete meta * - Delete meta
*/ */
class MangaQuery { class MangaQuery {
fun manga(dataFetchingEnvironment: DataFetchingEnvironment, id: Int): CompletableFuture<MangaType> { fun manga(dataFetchingEnvironment: DataFetchingEnvironment, id: Int): CompletableFuture<MangaType?> {
return dataFetchingEnvironment.getValueFromDataLoader<Int, MangaType>("MangaDataLoader", id) return dataFetchingEnvironment.getValueFromDataLoader("MangaDataLoader", id)
} }
enum class MangaSort { enum class MangaSort {