Merge branch 'master' into protobuf

server/src/main/kotlin/suwayomi/tachidesk/manga/MangaAPI.kt

@@ -7,7 +7,6 @@ package suwayomi.tachidesk.manga
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at https://mozilla.org/MPL/2.0/. */
 
-import io.javalin.Javalin
 import io.javalin.apibuilder.ApiBuilder.delete
 import io.javalin.apibuilder.ApiBuilder.get
 import io.javalin.apibuilder.ApiBuilder.patch
@@ -22,7 +21,7 @@ import suwayomi.tachidesk.manga.controller.MangaController
 import suwayomi.tachidesk.manga.controller.SourceController
 
 object MangaAPI {
-    fun defineEndpoints(app: Javalin) {
+    fun defineEndpoints() {
         path("extension") {
             get("list", ExtensionController::list)
 
@@ -82,7 +81,7 @@ object MangaAPI {
                 patch(":categoryId", LibraryController::categoryModify)
                 delete(":categoryId", LibraryController::categoryDelete)
 
-                patch(":categoryId/reorder", LibraryController::categoryReorder)
+                patch(":categoryId/reorder", LibraryController::categoryReorder) // TODO: the underlying code doesn't need `:categoryId`, remove it
             }
         }
 

server/src/main/kotlin/suwayomi/tachidesk/manga/controller/LibraryController.kt

@@ -54,10 +54,9 @@ object LibraryController {
 
     /** category re-ordering */
     fun categoryReorder(ctx: Context) {
-        val categoryId = ctx.pathParam("categoryId").toInt()
         val from = ctx.formParam("from")!!.toInt()
         val to = ctx.formParam("to")!!.toInt()
-        Category.reorderCategory(categoryId, from, to)
+        Category.reorderCategory(from, to)
         ctx.status(200)
     }
 }

server/src/main/kotlin/suwayomi/tachidesk/manga/impl/Category.kt

@@ -47,7 +47,7 @@ object Category {
     /**
      * Move the category from position `from` to `to`
      */
-    fun reorderCategory(categoryId: Int, from: Int, to: Int) {
+    fun reorderCategory(from: Int, to: Int) {
         transaction {
             val categories = CategoryTable.selectAll().orderBy(CategoryTable.order to SortOrder.ASC).toMutableList()
             categories.add(to - 1, categories.removeAt(from - 1))

server/src/main/kotlin/suwayomi/tachidesk/manga/impl/Search.kt

@@ -20,15 +20,18 @@ object Search {
     }
 
     // TODO
+    @Suppress("UNUSED_PARAMETER", "UNUSED_VARIABLE")
     fun sourceFilters(sourceId: Long) {
         val source = getHttpSource(sourceId)
         // source.getFilterList().toItems()
     }
 
+    @Suppress("UNUSED_PARAMETER")
     fun sourceGlobalSearch(searchTerm: String) {
         // TODO
     }
 
+    @Suppress("unused")
     data class FilterWrapper(
         val type: String,
         val filter: Any

server/src/main/kotlin/suwayomi/tachidesk/manga/impl/backup/legacy/LegacyBackupImport.kt

@@ -141,6 +141,7 @@ object LegacyBackupImport : LegacyBackupBase() {
      * @param history history data from json
      * @param tracks tracking data from json
      */
+    @Suppress("UNUSED_PARAMETER")
     private suspend fun restoreMangaData(
         manga: Manga,
         source: Source,
@@ -204,6 +205,7 @@ object LegacyBackupImport : LegacyBackupBase() {
         return fetchedManga
     }
 
+    @Suppress("UNUSED_PARAMETER") // TODO: remove this suppress when update Chapters is written
     private fun updateChapters(source: Source, fetchedManga: SManga, chapters: List<Chapter>) {
         // TODO("Not yet implemented")
     }

server/src/main/kotlin/suwayomi/tachidesk/manga/impl/backup/legacy/LegacyBackupValidator.kt

@@ -42,11 +42,11 @@ object LegacyBackupValidator {
                 .sorted()
         }
 
-        val trackers = mangas
-            .filter { it.asJsonObject.has("track") }
-            .flatMap { it.asJsonObject["track"].asJsonArray }
-            .map { it.asJsonObject["s"].asInt }
-            .distinct()
+//        val trackers = mangas
+//            .filter { it.asJsonObject.has("track") }
+//            .flatMap { it.asJsonObject["track"].asJsonArray }
+//            .map { it.asJsonObject["s"].asInt }
+//            .distinct()
 
         val missingTrackers = listOf("")
 //        val missingTrackers = trackers

server/src/main/kotlin/suwayomi/tachidesk/manga/impl/util/BytecodeEditor.kt

@@ -85,7 +85,7 @@ object BytecodeEditor {
                         bytes[2],
                         bytes[3]
                     )
-                    if (cafebabe.toLowerCase() != "cafebabe") {
+                    if (cafebabe.lowercase() != "cafebabe") {
                         // Corrupted class
                         return@use null
                     }

server/src/main/kotlin/suwayomi/tachidesk/server/JavalinSetup.kt

@@ -81,7 +81,7 @@ object JavalinSetup {
         app.routes {
             path("api/v1/") {
                 GlobalAPI.defineEndpoints()
-                MangaAPI.defineEndpoints(app)
+                MangaAPI.defineEndpoints()
                 AnimeAPI.defineEndpoints(app) // TODO: migrate Anime endpoints
             }
         }